feat(fvt): experiment with per-kafka-version image #2592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensure test clients are closed after use - increase initial delay, will be at least 10s to become ready so no point polling too early - bump default KAFKA_VERSION to 3.5.1 if not set Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
Switch to templating the Dockerfile and docker-compose so that each image is uniquely named and contains just the kafka version specified. This will make it easier to have a large matrix test for the main branch whilst keeping the PR checks at 2 or 3 kafka versions Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to templating the Dockerfile and docker-compose so that each
image is uniquely named and contains just the kafka version specified.
This will make it easier to have a large matrix test for the main branch
whilst keeping the PR checks at 2 or 3 kafka versions