chore(ci): replace toxiproxy client dep #2593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnwe
force-pushed
the
dnwe/toxiproxy
branch
5 times, most recently
from
af70b45
to
4e646db
Compare
The v2.5.0 client implementation happens to have a resource leak, and pulling in HEAD notably carries a large number of transitive dependencies that we don't really want to track in our go.mod just for FVT purposes. Therefore, knock up a minimal implementation of an http client for toxiproxy to satisfy our usage. Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v2.5.0 client implementation happens to have a resource leak, and pulling in HEAD notably carries a large number of transitive dependencies that we don't really want to track in our go.mod just for FVT purposes. Therefore, knock up a minimal implementation of an http client for toxiproxy to satisfy our usage.