fix(fvt): handle msgset vs batchset #2603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dnwe
commented
Aug 17, 2023
dnwe
commented
- update the TestFuncProducing tests to exercise a number of different client versions so we cover the old msgset (which the tests were originally written for) and batchset format, as well as all the currently supported versions of ProduceRequest
- relax some of the metrics validation to account for messages being sent in batches on the higher kafkaVersions
dnwe
force-pushed
the
dnwe/sarama-functional
branch
from
6c50cb6
to
00d99c9
Compare
dnwe
force-pushed
the
dnwe/functional-producer-versions
branch
from
f64705d
to
9054ff3
Compare
dnwe
force-pushed
the
dnwe/sarama-functional
branch
from
a86a950
to
5a8d6c3
Compare
dnwe
force-pushed
the
dnwe/functional-producer-versions
branch
from
9054ff3
to
2793309
Compare
dnwe
force-pushed
the
dnwe/sarama-functional
branch
from
5a8d6c3
to
26792a3
Compare
dnwe
force-pushed
the
dnwe/functional-producer-versions
branch
from
2793309
to
d2284f2
Compare
- update the TestFuncProducing tests to exercise a number of different client versions so we cover the old msgset (which the tests were originally written for) and batchset format, as well as all the currently supported versions of ProduceRequest - relax some of the metrics validation to account for messages being sent in batches on the higher kafkaVersions Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
dnwe
force-pushed
the
dnwe/functional-producer-versions
branch
from
d2284f2
to
8681621
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.