fix(fvt): fresh metrics registry for each test #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to nail down flakiness with the verification of metrics in these tests. Since adding the additional versions these have been flakey and I think the reason is that the registry is getting re-used between tests as it is only created fresh on a call to NewConfig Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
Batched test compression-ratio can sometimes be as low as 3 Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to nail down flakiness with the verification of metrics in these tests. Since adding the additional versions these have been flakey and I think the reason is that the registry is getting re-used between tests as it is only created fresh on a call to NewConfig