[WIP] Unite MessageToSend and ConsumerEvent #273
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start of #269.
ConsumerEvent
becomesConsumerMessage
and in the producer,MessageToSend
becomesProducerMessage
. Once we're ready to unite it I'd like to simply call itMessage
, but right now that is in used internally for messages between client and broker. Can we find a new name for this, e.g.BrokerMessage
orProtocolMessage
?[]byte
for keys and values.Still to resolve:
Metadata
, andErr
.