Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Unite MessageToSend and ConsumerEvent #273

Closed
wants to merge 2 commits into from
Closed

Conversation

wvanbergen
Copy link
Contributor

Start of #269.

  1. New names: ConsumerEvent becomes ConsumerMessage and in the producer, MessageToSend becomes ProducerMessage. Once we're ready to unite it I'd like to simply call it Message, but right now that is in used internally for messages between client and broker. Can we find a new name for this, e.g. BrokerMessage or ProtocolMessage?
  2. Remove encoder interface, and simply use []byte for keys and values.

Still to resolve: Metadata, and Err.

- ConsumerEvent: ConsumerMessage
- MessageToSend: ProducerMessage
@wvanbergen wvanbergen changed the title More consistent naming. [WIP] Unite MessageToSend and ConsumerEvent Feb 16, 2015
@wvanbergen
Copy link
Contributor Author

@mkobetic @Shopify/kafka

As discussed in out walkthrough of the new consumer.

@wvanbergen
Copy link
Contributor Author

Going to close this as this is outdated and I am not so sure about the approach anymore, I'll open an issue instead;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant