Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): disable checkout credentials persist #2812

Merged
merged 1 commit into from
Feb 27, 2024
Merged

chore(ci): disable checkout credentials persist #2812

merged 1 commit into from
Feb 27, 2024

Conversation

dnwe
Copy link
Collaborator

@dnwe dnwe commented Feb 22, 2024

We don't need actions/checkout to persist credentials for any submodules or other fetches. Whilst it is a read-only token, there's no need to leave it around on disk after the checkout has completed.

https://github.com/actions/checkout/blob/v4.1.1/action.yml#L48-L50

@dnwe dnwe added the ignore-for-release Label for PRs that shouldn’t be mentioned in release notes label Feb 22, 2024
We don't need actions/checkout to persist credentials for any submodules
or other fetches. Whilst it is a read-only token, there's no need to
leave it around on disk after the checkout has completed.

https://github.com/actions/checkout/blob/v4.1.1/action.yml#L48-L50

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
Copy link
Collaborator

@hindessm hindessm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnwe dnwe merged commit fd84c2b into main Feb 27, 2024
13 checks passed
@dnwe dnwe deleted the dnwe/ci branch February 27, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Label for PRs that shouldn’t be mentioned in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants