Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cpu spin loop when pending is closed while buf is not empty #2922

Conversation

AleksandrShibanov
Copy link

@AleksandrShibanov AleksandrShibanov commented Jun 5, 2024

it can be situation when
on line 854 pending is ok
on line 860 we add res to buf
on line 861 pending closes in other goroutine
and then there will be cpu spin loop.

I will be glad to see your suggestions and comments

@AleksandrShibanov
Copy link
Author

#2907

Copy link
Contributor

@puellanivis puellanivis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this resolves the immediate symptom, I’m unsure if this is a proper solution.

Copy link

github-actions bot commented Sep 4, 2024

Thank you for your contribution! However, this pull request has not had any activity in the past 90 days and will be closed in 30 days if no updates occur.
If you believe the changes are still valid then please verify your branch has no conflicts with main and rebase if needed. If you are awaiting a (re-)review then please let us know.

@github-actions github-actions bot added the stale Issues and pull requests without any recent activity label Sep 4, 2024
@github-actions github-actions bot closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues and pull requests without any recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants