producer: bugfix for broker flushers getting stuck #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eapache
force-pushed
the
fix-flusher-references
branch
2 times, most recently
from
84f13cc
to
7214846
Compare
In certain unusual circumstances, the producer could have added new references to a flusher that was shutting down, preventing it from shutting down and causing it to try to produce on a network connection that was already closed. Track "current" and "active" flushers separately - remove flushers from the "current" set immediately when they begin shutdown so that nothing else tries to take a reference, but leave them in "active" so that they can be cleaned up properly when their reference count hits 0. Add a test which fails without this fix in place.
eapache
force-pushed
the
fix-flusher-references
branch
from
7214846
to
24b047c
Compare
eapache
added a commit
that referenced
this pull request
Mar 18, 2015
producer: bugfix for broker flushers getting stuck
eapache
added a commit
that referenced
this pull request
Mar 19, 2015
Very similar to #367 (on the producer): the consumer could have added new references to a brokerConsumer that was shutting down, leading it to spin with an error unnecessarily. Add a test for this case.
eapache
added a commit
that referenced
this pull request
Mar 19, 2015
Very similar to #367 (on the producer): the consumer could have added new references to a brokerConsumer that was shutting down, leading it to spin with an error unnecessarily. Add a test for this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain unusual circumstances, the producer could have added new references
to a flusher that was shutting down, preventing it from shutting down and
causing it to try to produce on a network connection that was already closed.
Track "current" and "active" flushers separately - remove flushers from the
"current" set immediately when they begin shutdown so that nothing else tries to
take a reference, but leave them in "active" so that they can be cleaned up
properly when their reference count hits 0.
Add a test which fails without this fix in place.
@Shopify/kafka