Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

producer: bugfix for aggregators getting stuck #368

Merged
merged 2 commits into from
Mar 19, 2015
Merged

producer: bugfix for aggregators getting stuck #368

merged 2 commits into from
Mar 19, 2015

Commits on Mar 19, 2015

  1. DRY up a common producer test pattern

    @eapache
    eapache committed Mar 19, 2015
    Configuration menu
    Copy the full SHA
    c42b7aa View commit details
    Browse the repository at this point in the history

  2. producer: bugfix for aggregators getting stuck 

    In circumstances where Flush.Messages and/or Flush.Bytes were set but
Flush.Frequency was not, the producer's aggregator could get stuck on a retry
because a metadata-only chaser message would not be enough on its own to trigger
a flush, and so it would sit in limbo forever.

Always trigger a flush in the aggregator when the message is a chaser. This has
the additional benefit of reducing retry latency when Flush.Frequency *is* set.

Add a test for this case.
    @eapache
    eapache committed Mar 19, 2015
    Configuration menu
    Copy the full SHA
    a381b36 View commit details
    Browse the repository at this point in the history