The wiki of the offset API has been updated again #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should bring us up to date.
| Version int16 // 0 (0.8.1 and later) or 1 (0.8.2 and later, includes timestamp field) | ||
| blocks map[string]map[int32]*offsetCommitRequestBlock | ||
| ConsumerGroup string | ||
| ConsumerGroupGeneration int32 // v1 or later |
There was a problem hiding this comment.
Do you have any idea what this used for? Couldn't find anything useful in the wiki.
There was a problem hiding this comment.
|
minor comment other lgtm |
|
This LGTM. Not sure how long the approach of trying to support all version from one type is going to be sustainable, but for now |
.
eapache
added a commit
that referenced
this pull request
Mar 30, 2015
The wiki of the offset API has been updated again
|
@eapache @wvanbergen Seems Kafka 0.8.2 also not support kafka server: Offset's topic has not yet been created. CoordinatorID:-1 CoordinatorHost: CoordinatorPort:-1which is succeed in Kafka 0.8.2-beta. |
|
@wvanbergen Thanks for your advise, I'll try it later in 0.8.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should bring us up to date.
@Shopify/kafka
Somebody should verify against https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol#AGuideToTheKafkaProtocol-OffsetCommitRequest