Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: stop the background thread before closing #423

Merged
merged 2 commits into from
Apr 15, 2015
Merged

client: stop the background thread before closing #423

merged 2 commits into from
Apr 15, 2015

Commits on Apr 15, 2015

  1. client: stop the background thread before closing 

    Otherwise, in the rare case where a background metadata refresh coincided
exactly with a call to `Client.Close()` there was a race where we might have
potentially tried to write to a nil map. Also add a test for this.

Fixes #422.
    @eapache
    eapache committed Apr 15, 2015
    Configuration menu
    Copy the full SHA
    dd6ba39 View commit details
    Browse the repository at this point in the history

  2. Disable background metadata updater in a test 

    To catch if anybody accidentally breaks client startup/shutdown in this
configuration.
    @eapache
    eapache committed Apr 15, 2015
    Configuration menu
    Copy the full SHA
    52af5d9 View commit details
    Browse the repository at this point in the history