Fix another hypothetical wait group issue #451
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't increment and immediately decrement the wait group on a message which we
just return with ErrShuttingDown. Otherwise:
increment from 0 while being waited on
Where the WaitGroup docs say "calls with a positive delta that occur when the
counter is zero must happen before a Wait".
@Shopify/kafka @wvanbergen hopefully this explanation makes sense, it was the second issue I came up with from #450.