Clean up the flusher via helper methods #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if f.currentRetries[msg.Topic] != nil && f.currentRetries[msg.Topic][msg.Partition] != nil { | ||
| // we're currently retrying this partition so we need to filter out this message | ||
| f.parent.retryMessages([]*ProducerMessage{msg}, f.currentRetries[msg.Topic][msg.Partition]) | ||
| batch[i] = nil |
There was a problem hiding this comment.
actually some functional changes here; I re-orged a few of these lines so that we retry here before we do the chaser check; I don't think this really makes any difference
There was a problem hiding this comment.
👍 I can't really think that would disrupt anything - if anything this ordering is more logical.
|
🆒 👍 🚢 |
eapache
added a commit
that referenced
this pull request
Aug 13, 2015
Clean up the flusher via helper methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wvanbergen