Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Producer refactor #544

Closed
wants to merge 26 commits into from
Closed

Producer refactor #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
4fec243
Introduce the concept of a produceSet
eapache Sep 26, 2015
ab96424
Reorder some functions
eapache Sep 26, 2015
54d226d
Simplify parseResponse into parseBlock
eapache Sep 26, 2015
a5d3f67
Use eachPartition more
eapache Sep 26, 2015
e7b10b0
Construct the produceSet in the aggregator
eapache Sep 27, 2015
3d9d041
Move byte and msg-count tracking into the set
eapache Sep 27, 2015
f39d3be
Move key and value encoding back to buildRequest
eapache Sep 27, 2015
3405614
Fix offsets
eapache Sep 27, 2015
b72df33
Communicate responses back to the aggregator
eapache Sep 27, 2015
ef50cfe
Move closing and currentRetry logic into aggregator
eapache Sep 27, 2015
dc5a714
Rename aggregator to brokerProducer
eapache Sep 27, 2015
64ae474
Much needed cleanup
eapache Sep 27, 2015
2fd7980
Yet another useless (for now) abstraction
eapache Sep 27, 2015
72a1f9e
Construct message-sets as we go
eapache Sep 27, 2015
4f2a39c
Remove useless flush trigger
eapache Sep 27, 2015
54716f8
Don't set the timer if we couldn't add the message
eapache Sep 27, 2015
02e6f7c
Enable per-partition compressed size limits
eapache Sep 27, 2015
50a7916
Nil checks are now unnecessary
eapache Sep 27, 2015
ac14315
Remove more dead code
eapache Sep 27, 2015
3a54e97
Remove dead parameter
eapache Sep 27, 2015
8a9748b
Misc. fixes and cleanup
eapache Sep 27, 2015
7d7bf29
Comment to explain kafka's weird compression handling
eapache Sep 27, 2015
5363d82
Get rid of `pending` in the brokerProducer
eapache Sep 27, 2015
6516b87
This refactor just got a lot harder to swallow
eapache Sep 27, 2015
5fc13db
Refactor brokerProducer again
eapache Sep 27, 2015
78bec97
Destructure the flusher, it does nothing complex
eapache Sep 27, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading