Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kafka 0.9 #572

Merged
merged 3 commits into from
Nov 26, 2015
Merged

Add kafka 0.9 #572

merged 3 commits into from
Nov 26, 2015

Conversation

eapache
Copy link
Contributor

@eapache eapache commented Nov 26, 2015

Fix one new constraint on the broker ID which must now be small unless you
configure otherwise. Fortunately it seems older versions just ignore unrecognized config stanzas.

P.S. I believe this is because 0.9 now optionally auto-generates broker IDs for you within a given range? At some point we need to find/read a good changelog.

Fix one new constraint on the broker ID which must now be small unless you
configure otherwise.
@wvanbergen
Copy link
Contributor

👍

@eapache
Copy link
Contributor Author

eapache commented Nov 26, 2015

@wvanbergen review new extra commit please

@wvanbergen
Copy link
Contributor

👍 again :)

@eapache
Copy link
Contributor Author

eapache commented Nov 26, 2015

OK, failure is that before an OffsetFetch of a non-existent topic/partition would return ErrUnknownTopicOrPartition, now it just returns an offset of -1. I'll mimic the old behaviour for now so I don't have to think about compatibility too hard.

Looks like it has non-trivial problems we'll need to solve.
@eapache
Copy link
Contributor Author

eapache commented Nov 26, 2015

Added a skip, even working around that there are several problems with the offset manager. I'll file a ticket instead.

@eapache
Copy link
Contributor Author

eapache commented Nov 26, 2015

Filed #573 and #574.

eapache added a commit that referenced this pull request Nov 26, 2015
@eapache eapache merged commit c36adfa into master Nov 26, 2015
@eapache eapache deleted the kafka09 branch November 26, 2015 20:20
@jan4984
Copy link

jan4984 commented Dec 24, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants