Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream has spoken on retriable errors #589

Merged
merged 1 commit into from
Jan 4, 2016
Merged

Conversation

eapache
Copy link
Contributor

@eapache eapache commented Jan 2, 2016

Add InvalidMessage, and re-order the others to match their definition order.

Add InvalidMessage, and re-order the others to match their definition order.
@wvanbergen
Copy link
Contributor

When would a retry succeed? A topic that is in process of being created?

@eapache
Copy link
Contributor Author

eapache commented Jan 2, 2016

For ErrUnknownTopicOrPartition? When you have auto-create turned on.

@wvanbergen
Copy link
Contributor

No, I mean InvalidMessage, which IIRC gets returned when you use an invalid topic name (e.g. with a slash in it.

@eapache
Copy link
Contributor Author

eapache commented Jan 3, 2016

That's InvalidTopic - InvalidMessage indicates a bad CRC

@wvanbergen
Copy link
Contributor

D'oh. 👍 in that case

eapache added a commit that referenced this pull request Jan 4, 2016
Upstream has spoken on retriable errors
@eapache eapache merged commit 2b18ad7 into master Jan 4, 2016
@eapache eapache deleted the retriable-errors branch January 4, 2016 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants