Fix race condition on OffsetManager shutdown #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `updateCommitted` ran between the `Unlock` call and the read from `clean` then we might miss the transition message and hang. Instead, use a condition value from the `sync` package which does the right thing.
| if dirty { | ||
| <-pom.clean | ||
| for pom.dirty { | ||
| pom.clean.Wait() |
There was a problem hiding this comment.
I haven't seen sync.Cond used before. This looks like a pretty clean solution!
This seems to solve the issue with hanging, but could pom.dirty change to true after this goroutine finishes? I suppose this would only happen if MarkOffset is called after a Close, is it worth worrying about?
There was a problem hiding this comment.
calling anything after a Close or AsyncClose is user-error, not worth worrying about
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
updateCommittedran between theUnlockcall and the read fromcleanthen we might miss the transition message and hang. Instead, use a condition
value from the
syncpackage which does the right thing.@wvanbergen @hasnickl fixes #656
Supersedes #657