Consumer: reduce timer allocations #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as i mentioned in the other ticket, profile looks a lot better, and it looks like my app still consumes data fine as well ;) |
Dieterbe
added a commit
to grafana/metrictank
that referenced
this pull request
Jul 27, 2016
pulled in the dependencies how i had them in my $GOPATH in particular it comes with a Sarama allocation fix IBM/sarama#712
Closed
|
Hi guys. I think the timer was used incorrectly here. As mentioned in the package document, we should call timer's Stop method before reuse a timer. Link. And the current codes lead to logs like "abandoned subscription to Topic because consuming was taking too long". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than allocating a new timer with
time.Afteron every message weconsume, allocate one for the
responseFeederand just keep resetting it.Thanks to @Tevic for suggesting this approach.
Fixes #707 cc @Dieterbe.