fix erronous errTimedOut ("abandoned subscription...because consuming… #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… was taking too long") The expiryTimer continues to run after msg is delivered to child.messages. If <-child.feeder takes > MaxProcessingTime (which depends on how fast the broker runs), the expiryTimer can expire before we Reset() it. If this happens there is a message waiting in expiryTimer.C which, if we don't clear it out, makes us think the consumer stalled. This is reproduced with a high traffic partition on a busy broker, and measuring the time each line of the loop takes. The >100ms stall is the <-child.feeder inside 'range child.feeder'.
|
Nice catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… was taking too long")
The expiryTimer continues to run after msg is delivered to
child.messages. If <-child.feeder takes > MaxProcessingTime (which
depends on how fast the broker runs), the expiryTimer can expire
before we Reset() it. If this happens there is a message waiting
in expiryTimer.C which, if we don't clear it out, makes us think
the consumer stalled.
This is reproduced with a high traffic partition on a busy
broker, and measuring the time each line of the loop takes. The