add new version kafka and apiversions support #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvanbergen
reviewed
Apr 11, 2017
|
|
||
| return response, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
Can you add a test for this new API?
There was a problem hiding this comment.
i have already add this test in broker_test.go
|
One final thing: can you rebase your branch and get squash the last 4 commits into one? |
add apiversions in broker
|
i have do the rebase and squash |
|
@eapache final 👀 before merging this? |
eapache
approved these changes
Apr 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.