negative timestamps on messages fix #907
Conversation
|
I assume you mean to return an error when trying to encode a bad packet? Kafka is returning messages with I'll make the following changes for the encoding part:
Does this sound good? |
message.go
Outdated
| pe.putInt64(m.Timestamp.UnixNano() / int64(time.Millisecond)) | ||
| timestamp := int64(-1) | ||
|
|
||
| if m.Timestamp.After(time.Unix(0, -1)) { |
There was a problem hiding this comment.
looking at the actual implementation (https://golang.org/src/time/time.go?s=29125:29162#L991), did you mean time.Unix(0, 0)?
There was a problem hiding this comment.
or perhaps it would be simpler to just do !Before a zero time, which is cleaner to construct
There was a problem hiding this comment.
I inverted the condition to use !m.Timestamp.Before as you suggested. Let me know if there is anything else.
* Negative timestamps on messages are invalid thus this commit adds checks for them. On decoding, this returns a zero time for negative timestamps for easy validity checking. On encoding, zero times will be encoded as -1, anything else before Unix epoch returns an error.
timestamps are invalid. On decoding, return a zero time for easy
existence checking. On encoding, set timestamp to be -1 if the
given time describes a time before unix epoch.