Added more tests for config validation #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eapache - Does not look like related to my change. |
eapache
reviewed
Oct 6, 2017
config_test.go
Outdated
| func TestNetConfigValidates(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| cfg func() *Config // resorting to using a function as a param because of internal composite structs |
There was a problem hiding this comment.
change the method sig to func(*Config) and have the loop create the new config each time; will reduce the size of all the function bodies
|
Sometimes that CI error happens if the kafka cluster does not boot properly, I can trigger a re-run if it happens again. |
Passing the cfg pointer in the function and creating the initial config from the main test loop
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.