Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for varint encoded fields #972

Merged
merged 4 commits into from
Oct 25, 2017
Merged

Add support for varint encoded fields #972

merged 4 commits into from
Oct 25, 2017

Conversation

wladh
Copy link
Contributor

@wladh wladh commented Oct 25, 2017

Kafka 0.11 Record uses varint encoding for most fields.
Issue #901

vlad-arista and others added 4 commits October 24, 2017 16:41
Kafka 0.11 uses varint to encode most of the fields in the new Records.
Kafka 0.11 encodes Record length as varint.
Add support for Castagnoli polynomial for CRC32 computation
@eapache
Copy link
Contributor

eapache commented Oct 25, 2017

Travis is still having problems, and codecov is complaining, but this will get coverage when the actual Record struct is added with tests.

@eapache eapache merged commit 84ac271 into IBM:master Oct 25, 2017
@wladh wladh deleted the varints branch October 26, 2017 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants