-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying to test for 3.12 (update packages if necessary) #44
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Seemingly the toolkit is working for python 3.10, 3.11 and 3.12 using torch == 2.3.*, considering the flexible versions defined on |
these requirements files should now really only be updated through accepting PRs from dependabot, and they should always have exactly pinned versions. For requirements like |
The problem is that the automatic tests use these files to create the environment and the previously fixed versions have conflicts with python3.12. |
Maybe we could create a kind of conditional for the requirements when switching between versions. |
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
I defined new fixed versions for the packages in |
lgtm - fix conflicts..then merge |
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@carlos @romeokienzler The tests are now passing for 3.12, but they conflict with mmseg-related dependencies. I removed them and left them as optional for the user, that means, all the imports are conditional and hidden (using importlib) and it should not affect the general working. |
No description provided.