Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chat api format with standard open ai chat format #1314

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

elronbandel
Copy link
Member

No description provided.

Signed-off-by: elronbandel <elronbandel@gmail.com>
Signed-off-by: elronbandel <elronbandel@gmail.com>
src/unitxt/formats.py Outdated Show resolved Hide resolved
Signed-off-by: elronbandel <elronbandel@gmail.com>
Signed-off-by: elronbandel <elronbandel@gmail.com>
Signed-off-by: elronbandel <elronbandel@gmail.com>
@yoavkatz
Copy link
Member

yoavkatz commented Oct 30, 2024

@elronbandel - I think we should make this self contained

  1. Add a HF inference engine (that uses the chat API)
  2. Add en example code that calls this API both as text and with image.

@OfirArviv
Copy link
Collaborator

OfirArviv commented Oct 30, 2024

  • Add a HF inference engine (that uses the chat API)
  • Add en example code that calls this API both as text and with image.

We should wait for Pawel pr for this. The changes to the inference engine are minimal. No need to duplicate it. Right now no one is waiting for this. Im the one who asked for it, so no pressure I think

Signed-off-by: elronbandel <elronbandel@gmail.com>
Signed-off-by: elronbandel <elronbandel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants