doc(vcl/sharding): add precision and fix acl syntax #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Zinck <zinck.arthur4@gmail.com>
arthurzinck
force-pushed
the
docs/advance-vcl-sharding/add-information
branch
from
027ec24
to
728d2f6
Compare
Signed-off-by: Arthur Zinck <zinck.arthur4@gmail.com>
arthurzinck
force-pushed
the
docs/advance-vcl-sharding/add-information
branch
from
728d2f6
to
2e76d10
Compare
cin
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
Odd, I know we were using this configuration a while back. Maybe it broke w/one of the version updates. What was the error you were getting? Just curious.
Approving but I doubt this will get merged unfortunately as no one at IBM is actively maintaining this project any longer. I have a fork that can be used going forward, but I think this repo is going to get archived eventually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I had issues line 310 with the syntax and since I added
/32inside the quotes it worked.I added precision line 372, it can be
hashand if you set it tohashit will load the answer into the cache of your varnish instance, versuspassit will ask for the answer each time and will not load it into Varnish instance's cache.Thanks,
Arthur
Issue.
#104