-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding multi-platform support for linux/amd64 and linux/arm64 #83
Conversation
Added `--platform` option to `docker build` commands in e2e tests Added `PLATFORM` variable to Makefile for local builds Golang version update Dependency updates Signed-off-by: Craig Ingram <cingram@us.ibm.com>
Signed-off-by: Craig Ingram <cingram@us.ibm.com>
Signed-off-by: Craig Ingram <cingram@us.ibm.com>
Signed-off-by: Craig Ingram <cingram@us.ibm.com>
Signed-off-by: Craig Ingram <cingram@us.ibm.com>
Problem only shows when updating the kubebuilder-tools to 1.25.0 (when the v1beta policy was deprecated) Signed-off-by: Craig Ingram <cingram@us.ibm.com>
Added podman support for e2d tests Signed-off-by: Craig Ingram <cingram@us.ibm.com>
Tied to use the `--load` option instead of `--push` but didn't work May be a Rancher Desktop issue > error: docker exporter does not currently support exporting manifest lists Signed-off-by: Craig Ingram <cingram@us.ibm.com>
`podman buildx` auto-loads the image into the local docker repo `podman buildx` doesn't support `--push` arg `docker pull` is not necessary with podman Refactored create_dev_cluster.sh Signed-off-by: Craig Ingram <cingram@us.ibm.com>
I think this is working, but I don't have a good way of testing the arm images. I've tried building images on a few different configurations as well. I'm using Rancher Desktop on a 2018 Intel based mac, podman on a 2021 m1 mac, and Docker Desktop on WSL under windows. The only issue I'm having is with the images produced by podman. It doesn't have arm64 and amd64 manifests in the image.
I think the only way I will know if the build works under GHA is to merge/tag it. I'm also having issues on the m1 mac with the e2e-tests. The create script is failing to load the images onto the kind cluster's nodes. This happens with the other images as well, so it's not just an issue with the podman produced images. The e2e-tests work fine under WSL and my old mac. TLDR: more testing is needed at this point to determine what's going on with the m1 mac and podman. |
e2e-tests failure on m1 mac w/podman built images:
|
Added both platforms to docker build commands in e2e-tests Signed-off-by: Craig Ingram <cingram@us.ibm.com>
Signed-off-by: Craig Ingram <cingram@us.ibm.com>
Signed-off-by: Craig Ingram <cingram@us.ibm.com>
Mainly for testing different platform and build configurations Signed-off-by: Craig Ingram <cingram@us.ibm.com>
Signed-off-by: Craig Ingram <cingram@us.ibm.com>
Signed-off-by: Craig Ingram <cingram@us.ibm.com>
Signed-off-by: Craig Ingram <cingram@us.ibm.com>
Signed-off-by: Craig Ingram <cingram@us.ibm.com>
Signed-off-by: Craig Ingram <cingram@us.ibm.com>
Still needs testing as I'm sure I've left something out.
Resolves #81