Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub actions for CI and release #57

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ThePrez
Copy link
Member

@ThePrez ThePrez commented Feb 14, 2022

PR is a mere suggestion as an alternative to Jenkins-based builds. I have no assertion that this PR should or need to land, but could be an interesting discussion

@kadler
Copy link
Member

kadler commented Feb 14, 2022

This is way more complicated than the Jenkins build, though the Jenkins build is more complicated on the backend (ie you need Jenkins set up).

@ThePrez
Copy link
Member Author

ThePrez commented Feb 14, 2022

This is way more complicated than the Jenkins build, though the Jenkins build is more complicated on the backend (ie you need Jenkins set up).

I agree. Though one benefit of the GH actions approach is that it can build a release and publish it to the GitHub release. Jenkins can probably do that too (and I am not sure how much utility there is, given it still ultimately ends up in a PTF)

@ThePrez
Copy link
Member Author

ThePrez commented Feb 15, 2022

Really should have folded #50 into these, since I also made a make target for a save file but in a much more rudimentary capacity

@kadler
Copy link
Member

kadler commented Feb 15, 2022

I agree. Though one benefit of the GH actions approach is that it can build a release and publish it to the GitHub release. Jenkins can probably do that too (and I am not sure how much utility there is, given it still ultimately ends up in a PTF)

I believe I have some code to do that IIRC. Got sidetracked testing with various compression tools to compress the save files since they are so big.

@kadler
Copy link
Member

kadler commented Feb 15, 2022

Changes here: https://github.com/IBM/xmlservice/compare/create-release?expand=1

Creates 3 XZ-compressed save files:

  • xmlservice.savf.xz: includes just the programs and service programs for XMLSERVICE
  • xmlservice-tests.savf.xz includes just the tests, making it easy to run various itoolkit tests
  • xmlservice-full.savf.xz: includes everything

Example release built by the branch: https://github.com/IBM/xmlservice/releases/tag/test-tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants