New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Issue #31 and open diagnostics view when compile error occurs #36

Merged

petenicholls merged 2 commits into develop from LintUpdates

Jan 11, 2019

Contributor

guychris commented Jan 8, 2019

fix the regular expression used for compilation errors to allow for apps with no namespace, issue Regex for linting build messages breaks when building an application that's not in a namespace #31.
open the diagnostics view automatically if any compilation errors occur.

found tangentially related issue #35 while investigating this.

Christian Guy added 2 commits

January 8, 2019 14:16


          If a compilation error is sent to linter, open Diagnostics view.

f1c05f1


          issue #31 Update compiler error message regex to match files with no …

29f9a28

…namespace

guychris requested a review from petenicholls

January 8, 2019 19:44

petenicholls approved these changes

View reviewed changes

petenicholls merged commit 9ab2f15 into develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet