Skip to content

Commit

Permalink
Merge pull request #1856 from IBMa/joho-smallReportChanges-1853
Browse files Browse the repository at this point in the history 
fix(extension): Small text changes and Excel image of Checker reports
  • Loading branch information
@ErickRenteria
ErickRenteria authored Apr 9, 2024
2 parents d22f914 + 216c41d commit 902fd9c
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 19 deletions.
Binary file added accessibility-checker-extension/src/assets/img/7_1_ReportXLS_hidden.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion accessibility-checker-extension/src/ts/devtools/components/reportSection.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ export class ReportSection extends React.Component<ReportSectionProps, ReportSec
disabled={totalCount === 0}
style={{ float: "right", marginRight: "16px", minHeight: "18px", maxHeight: "32px" }}
onClick={() => devtoolsController.exportXLS("last") }
>Export XLS</Button>
>Export scan</Button>
</div>
</div>
</div>
Expand Down
6 changes: 3 additions & 3 deletions accessibility-checker-extension/src/ts/devtools/components/scanSection.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -350,11 +350,11 @@ export class ScanSection extends React.Component<{}, ScanSectionState> {
ariaLabel="stored scans"
renderIcon={ChevronDown}
>
<OverflowMenuItem
{/* <OverflowMenuItem
disabled={!this.state.reportContent}
itemText="Download current scan"
onClick={() => devtoolsController.exportXLS("last") }
/>
/> */}
<OverflowMenuItem
// if scanStorage false not storing scans, if true storing scans
itemText= {this.state.storeReports ? "Stop storing scans" : "Start storing scans"}
Expand All @@ -364,7 +364,7 @@ export class ScanSection extends React.Component<{}, ScanSectionState> {
/>
<OverflowMenuItem
disabled={this.state.storedReportsCount === 0} // disabled when no stored scans or 1 stored scan
itemText="Download stored scans"
itemText="Export stored scans"
onClick={() => devtoolsController.exportXLS("all") }
/>
<OverflowMenuItem
Expand Down
24 changes: 12 additions & 12 deletions accessibility-checker-extension/src/ts/docs/UsingACApp.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1015,11 +1015,11 @@ class UsingACApp extends React.Component<{}, UsingACAppState> {
This interactive report is in an HTML web format that includes:
</p></p>
<OrderedList>
<ListItem>The scan date and time</ListItem>
<ListItem>The scanned URL</ListItem>
<ListItem>Scan date and time</ListItem>
<ListItem>URL scanned</ListItem>
<ListItem>Percentage of elements with no detected violations or items to review</ListItem>
<ListItem>A summary of test results </ListItem>
<ListItem>Issue details organized by requirements, element roles, and rules</ListItem>
<ListItem>Summary of test results </ListItem>
<ListItem>Issue details organized by Requirements or by Rules</ListItem>
<ListItem>‘Learn more’ link with detailed help description for each issue</ListItem>
</OrderedList>
<p>
Expand All @@ -1038,8 +1038,8 @@ class UsingACApp extends React.Component<{}, UsingACAppState> {
</p>
<p>
<img
src="assets/img/7_1_ReportXLS.png"
alt="an excel spreadsheet of an accessibility scan report"
src="assets/img/7_1_ReportXLS_hidden.png"
alt="an Excel spreadsheet of an accessibility scan report"
/>
</p>
<OrderedList>
Expand All @@ -1054,9 +1054,9 @@ class UsingACApp extends React.Component<{}, UsingACAppState> {
<strong>Issue Summary</strong> provides an overview of the issues found across all the scans.
Issues are summarized in a prioritized order, starting with Level 1 items,
as defined in the IBM Equal Access Toolkit, followed by Level 2 and Levels 3
and 4. Levels 1-3 are necessary to complete the IBM requirements. Within each
and 4. Levels 1-3 are necessary to complete the IBM accessibility requirements. Within each
level, the summary lists issues that are Violations, items that Need Review,
and Recommendations. Counts are provided for each type of issue.
Recommendations, and Hidden. Totals and counts are provided for each type of issue.
</ListItem>
<ListItem>
<strong>Issues</strong> has the details of the individual issues. This includes the scan label
Expand All @@ -1068,9 +1068,9 @@ class UsingACApp extends React.Component<{}, UsingACAppState> {
</ListItem>
</OrderedList>
<p>
<strong>Note</strong>: If the same page is scanned multiple times in a multi-scan report,
there may be duplicate issues, which can be identified as having the same Issue ID.
If a template or reused component has issues, these will also be repeated in the report, but may have different Issue IDs.
<strong>Note</strong>: If the same page is scanned multiple times,
there will be duplicate issues in the multi-scan report, which can be identified as having the <strong>same</strong> Issue ID.
If a template or reused component has issues, these will also be repeated in the report, but will have <strong>different</strong> Issue IDs.
</p>

<h2 id="a11y_considerations">7. Accessibility features</h2>
Expand Down Expand Up @@ -1114,7 +1114,7 @@ class UsingACApp extends React.Component<{}, UsingACAppState> {
/>{" "} opens/closes the menu dropdown
</ListItem>
<ListItem>Filter, <img src={enter} alt="enter key"/> opens/closes the menu dropdown</ListItem>
<ListItem>Export XLS, <img src={enter} alt="enter key"/> downloads reports</ListItem>
<ListItem>Export scan, <img src={enter} alt="enter key"/> downloads reports</ListItem>
<ListItem>Issues, <img src={space} alt="space bar"/> selects all issues</ListItem>
<ListItem>Issue groupings, <img
src={leftRight}
Expand Down
6 changes: 3 additions & 3 deletions ...ibility-checker-extension/src/ts/util/xlsxReport/multiScanReport/xlsx/MultiScanReport.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ export default class MultiScanReport {
// Scans info Headers
worksheet.getRow(12).height = 16; // actual height is

const cellA12 = worksheet.getCell('A12'); cellA12.value = "Total issues";
const cellA12 = worksheet.getCell('A12'); cellA12.value = "Issues";
const cellB12 = worksheet.getCell('B12'); cellB12.value = "Violations";
const cellC12 = worksheet.getCell('C12'); cellC12.value = "Needs review";
const cellD12 = worksheet.getCell('D12'); cellD12.value = "Recommendations";
Expand Down Expand Up @@ -560,7 +560,7 @@ export default class MultiScanReport {
cellA2.fill = { type: 'pattern', pattern: 'solid', fgColor: { argb: 'FFFFFFFF' } };

const cellB2 = worksheet.getCell("B2");
cellB2.value = "Number of issues";
cellB2.value = "Issues";
cellB2.alignment = { vertical: "middle", horizontal: "right" };
cellB2.font = { name: "Calibri", color: { argb: "FF000000" }, size: 12 };
cellB2.fill = { type: 'pattern', pattern: 'solid', fgColor: { argb: 'FFE3E3E3' } };
Expand All @@ -587,7 +587,7 @@ export default class MultiScanReport {
totalIssuesRow.height = 27; // actual is 36

const cellA3 = worksheet.getCell("A3");
cellA3.value = "Total issues found:";
cellA3.value = "Issues found:";
cellA3.alignment = { vertical: "middle", horizontal: "left" };
cellA3.font = { name: "Calibri", color: { argb: "FFFFFFFF" }, size: 16 };
cellA3.fill = { type: 'pattern', pattern: 'solid', fgColor: { argb: 'FF000000' } };
Expand Down

0 comments on commit 902fd9c

Please sign in to comment.