Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to montex code #11

Merged
merged 2 commits into from
Jun 16, 2022
Merged

update to montex code #11

merged 2 commits into from
Jun 16, 2022

Conversation

vinorodrigues
Copy link

Hey there,

I've updated the code a bit - more aligned with the recent 0.17.0 release. Changes are (in summary):

  • remove VIA_QMK_RGBLIGHT_ENABLE - in 0.17.0 this will actually cause a compile error as is.
  • more data driven config - moved things like matrix, debounce, usb id's etc, to the config.json file as the QMK admins push to "data driven" configuration
  • simple copyright headers - using short notation for copyright headers
  • readme image on imgur - for some reason the QMK admins are insisting the product images be hosted on imgur
  • some code cleanup

If you just merge this into yours then the QMK PR will also have it. Once done I can then get on discord and encourage them to relook and merge it.

@IBNobody IBNobody merged commit 5fd58d0 into IBNobody:idobao_montex_v2 Jun 16, 2022
@vinorodrigues vinorodrigues deleted the idobao_montex_v2_fix_1 branch June 16, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants