Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added in arrays to collect per-atom descriptors and gradients #11

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jmgoff
Copy link

@jmgoff jmgoff commented Oct 6, 2022

  • Arrays B_all and neighbours_dB were added to collect descriptors and descriptor gradients, respectively.
  • To break out descriptor contributions per atom, other intermediate arrays were added (weights_rank1_dB and weights_dB for gradient breakout).
  • Descriptors and descriptor gradients may be collected and printed using the LAMMPS compute. This compute is implemented in the 'compute-pace' branch here.

@yury-lysogorskiy
Copy link
Member

@jmgoff I added more general and controllable implementation of gradients for both ACEBEvaluator and ACECTildeEvaluator in feature/b-grad branch. Could you, please, check if that will work with your compute pace ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants