Numpy 2.0 compatibility #1420
Numpy 2.0 compatibility #1420
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1420 +/- ##
===========================================
+ Coverage 82.02% 83.89% +1.86%
===========================================
Files 160 160
Lines 13107 13107
===========================================
+ Hits 10751 10996 +245
+ Misses 2356 2111 -245 ☔ View full report in Codecov by Sentry. |
setup.cfg
Outdated
| @@ -47,7 +47,7 @@ keywords = | |||
|
|
|||
| [options] | |||
| install_requires = | |||
| numpy >= 1.19.1, != 1.24.0 | |||
| numpy >= 2.0 | |||
There was a problem hiding this comment.
None of the changes here requires numpy >= 2.0, right?
| @@ -47,7 +47,7 @@ keywords = | |||
|
|
|||
| [options] | |||
| install_requires = | |||
| numpy >= 1.19.1, != 1.24.0 | |||
| numpy >= 1.19.1, != 1.24.0, < 2.0 | |||
There was a problem hiding this comment.
I think either requiring <2.0 or >=2.0 will be a pain to users, so I'd avoid that here.
The current issue with nlopt can be solved by installing numpy<2.0 specifically in the respective tox env. (Consider opening an nlopt issue regarding numpy2.0 support if there isn't any yet.)
There was a problem hiding this comment.
Agreed. Changed it accordingly for now.
Changed through
ruff check path/to/code/ --select NPY201as explained here