Skip to content

Commit

Permalink
Introduce isort linting
Browse files Browse the repository at this point in the history
This commit adds isort to the list of development requirements, and
introduces the required changes so that isort checks successfully our
repository. We were already doing a pretty good job, with only some
minor corrections that were required. The lint CI job has also been
updated to run this check.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
  • Loading branch information
rtobar committed Aug 20, 2024
1 parent 831f2b9 commit 7088759
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,5 @@ jobs:
run: mypy --strict src test
- name: Run black
run: black --check .
- name: Run isort
run: isort --check --diff .
1 change: 1 addition & 0 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Keep alphasorted
black
isort
mypy
pytest
wheel
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
#
import glob

from setuptools import setup, Extension
from setuptools import Extension, setup

crcmod_ext = Extension(
"crc32c._crc32c",
Expand Down
2 changes: 1 addition & 1 deletion test/test_crc32c.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
import os
import struct
import warnings
from typing import Any, Generator, NamedTuple, List
from typing import Any, Generator, List, NamedTuple

import pytest

Expand Down

0 comments on commit 7088759

Please sign in to comment.