Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up add notebook duplication in readme #130

Merged
merged 10 commits into from
Sep 6, 2024

Conversation

dangunter
Copy link
Member

@dangunter dangunter commented Aug 6, 2024

Developer README cleanup

Fixes #120

  • Also fixed a minor issue with the default xdist (for parallel execution) 'worker', setting that to be the master (gw0) let the tests run in my environment.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

📚 Documentation preview 📚: https://idaes-examples--130.org.readthedocs.build/en/130/

@dangunter dangunter self-assigned this Aug 6, 2024
@dangunter dangunter added the documentation Improvements or additions to documentation label Aug 6, 2024
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Aug 8, 2024
@lbianchi-lbl
Copy link
Contributor

I've added a CI step to run pytest . to verify that this indeed resolves #112, and reverted (and subsequently re-reverted) 9f2d61b to check that the newly added step would cause the job to fail without that change (done in 8f62fcb). So, as far as #112 is concerned, this is good to go!

Copy link
Contributor

@lbianchi-lbl lbianchi-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see, I think this addresses the main issue of duplicated text in the developer README.

@lbianchi-lbl lbianchi-lbl merged commit 1ee11cf into IDAES:main Sep 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Priority:Normal Normal Priority Issue or PR
Projects
None yet
3 participants