Hide Pysmo warnings in tests #1428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangunter
requested review from
andrewlee94,
bpaul4,
rundxdi,
dallan-keylogic,
lbianchi-lbl and
ksbeattie
as code owners
dallan-keylogic
approved these changes
Jun 3, 2024
Comment on lines
13
to
15
| # TODO: Missing doc strings | ||
| # pylint: disable=missing-module-docstring | ||
| # pylint: disable=missing-function-docstring |
There was a problem hiding this comment.
Can we get rid of these Pylint disables now?
There was a problem hiding this comment.
I wasn't looking at that, but sure should be an easy fix while I'm breaking things in those files
bpaul4
reviewed
Jun 10, 2024
| @staticmethod | ||
| def print_fun(x, f, accepted): | ||
| print("at minimum %.4f accepted %d" % (f, int(accepted))) | ||
| # @staticmethod |
| print( | ||
| "\n===========================Polynomial Regression===============================================\n" | ||
| ) | ||
| # print( |
| # print( | ||
| # "\n===========================Polynomial Regression===============================================\n" | ||
| # ) | ||
| _log.info("Polynomial Regression (begin)") | ||
| # Checks if fname is provided or exists in the path | ||
| if not isinstance(overwrite, bool): | ||
| # PYLINT-TODO |
There was a problem hiding this comment.
pylint disable-next=broad-exception-raised is used in a few places in this file, are they still necessary?
| '".\n', | ||
| _log.warning( | ||
| f"Warning: '{fname}' exists, " | ||
| f"results will be saved to {self.filename}" | ||
| ) | ||
| # self.filename = 'solution.pickle' |
There was a problem hiding this comment.
This is commented, but seems like it was already commented out before this PR.
| ) | ||
| self.number_of_crossvalidations = number_of_crossvalidations | ||
| # warnings.warn(msg) |
There was a problem hiding this comment.
Same here, commented out line
| ) | ||
| maximum_polynomial_order = 10 | ||
| self.max_polynomial_order = maximum_polynomial_order | ||
| # warnings.warn(msg) |
| @@ -1274,11 +1293,12 @@ def polynomial_regression_fitting(self, additional_regression_features=None): | |||
| < self.original_data.shape[0] | |||
| ) | |||
| ): | |||
| print("\n-------------------------------------------------") | |||
| print("\nIteration ", iteration_number) | |||
| # print("\n-------------------------------------------------") | |||
| " / MSE: %4f" % mse_error_opt, | ||
| " / R_sq: %4f" % r_square_opt, | ||
| " / Adjusted R^2: %4f" % r_square_adj_opt, | ||
| # print( |
| KrigingClass.print_fun(1, 2, 3.7) | ||
| sys.stdout = sys.__stdout__ | ||
| assert "at minimum 2.0000 accepted 3\n" == capturedOutput.getvalue() | ||
| # @pytest.mark.unit |
There was a problem hiding this comment.
Was this left commented on purpose, or can this be removed?
| @@ -1647,7 +1661,7 @@ def test_results_generation_01(self, array_type1, array_type2): | |||
| row_list = np.array([["k"], ["(x_1)^1"], ["(x_2)^1"]]) | |||
| expected_df = pd.concat( | |||
| [ | |||
| expected_df, | |||
| #expected_df, | |||
There was a problem hiding this comment.
Commented here, and in a couple places farther down in this file
|
Superseded by #1472 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1421
Summary/Motivation:
They are annoying
Changes proposed in this PR:
pylint-disablecommentsLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: