Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limiting pint version #1438

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Limiting pint version #1438

merged 1 commit into from
Jun 17, 2024

Conversation

andrewlee94
Copy link
Member

Fixes None

Summary/Motivation:

Pint recently released v0.24 which changed some behavior in how dimensionless quantities are displayed and thus causes tests to start failing. However, v0.24 is only supported on Python 3.10 and greater, and thus we cannot switch tho the new version as we still support older version of Python.

Changes proposed in this PR:

  • Limit pint version to <0.24

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@andrewlee94 andrewlee94 self-assigned this Jun 17, 2024
@andrewlee94 andrewlee94 added Priority:High High Priority Issue or PR dependencies Pull requests that update a dependency file labels Jun 17, 2024
@andrewlee94 andrewlee94 enabled auto-merge (squash) June 17, 2024 14:10
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.79%. Comparing base (2ac6417) to head (4cf9b11).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1438      +/-   ##
==========================================
- Coverage   77.80%   77.79%   -0.01%     
==========================================
  Files         393      393              
  Lines       64797    64797              
  Branches    14390    14390              
==========================================
- Hits        50413    50410       -3     
- Misses      11794    11798       +4     
+ Partials     2590     2589       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewlee94 andrewlee94 merged commit fff4546 into IDAES:main Jun 17, 2024
53 checks passed
@andrewlee94 andrewlee94 deleted the pint_version branch June 17, 2024 15:23
lbianchi-lbl added a commit to lbianchi-lbl/idaes-ui that referenced this pull request Jun 21, 2024
lbianchi-lbl added a commit to IDAES/idaes-ui that referenced this pull request Jun 21, 2024
* Move testing dependencies to extras_require and remove dev target

* Add pytest importorskip for optional dependencies

* Use Action from PR instead of main

* Remove FastAPI code and dependencies for the time being

* Remove unused code causing error message shown during tests

* Add pint version constraint for compat with unreleased IDAES/idaes-pse#1438
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants