-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add UI return, then visualize() can return now #1466
add UI return, then visualize() can return now #1466
Conversation
… save_diagram etc.
…I code, this way has no need to up date PSE when want to update return items in UI
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1466 +/- ##
==========================================
- Coverage 76.37% 76.36% -0.01%
==========================================
Files 393 393
Lines 65085 65086 +1
Branches 14426 14426
==========================================
- Hits 49708 49705 -3
- Misses 12815 12820 +5
+ Partials 2562 2561 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from these minor changes.
update return to snake_case Co-authored-by: Ludovico Bianchi <lbianchi@lbl.gov>
…his module Co-authored-by: Ludovico Bianchi <lbianchi@lbl.gov>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more minor issue with the Sphinx rendering.
…lt:` prefix. This prevents Sphinx from incorrectly adding an extra "Return type" field in the documentation. Co-authored-by: Ludovico Bianchi <lbianchi@lbl.gov>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but a test would be nice. Will add another issue
Fixes
Add return to UI.visualize() then user can use visualize() returned value and functions
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: