-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for Python 3.8 #1467
Remove support for Python 3.8 #1467
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one non-critical comment.
There is one mention on Python 3.8 on the FAQ page: https://github.com/IDAES/idaes-pse/blob/main/docs/explanations/faq.rst. The pywin32
issue may be relevant to other Python version, in which case we could leave the FAQ as-is.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1467 +/- ##
==========================================
- Coverage 76.38% 76.37% -0.01%
==========================================
Files 394 394
Lines 65108 65108
Branches 14423 14423
==========================================
- Hits 49732 49729 -3
- Misses 12814 12818 +4
+ Partials 2562 2561 -1 ☔ View full report in Codecov by Sentry. |
Good point, I did notice this as well and opted for leaving it in for the same reason you mentioned. I propose to leave that in unless someone objects. |
@lbianchi-lbl @bpaul4 I suggest we keep the discussion as well, but add a note to indicate that Python 3.8 is no longer officially supported (i.e. make it clear we left this comment there for those who wish to try (or have similar issues), but that we don't guarantee that the rest of the code will work). |
05fef3a
to
4696841
Compare
@andrewlee94 I've added a note there (and the same to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #1462
Changes proposed in this PR:
setup.py
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: