Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move UI to react #25

Merged
merged 336 commits into from
Oct 6, 2023
Merged

Move UI to react #25

merged 336 commits into from
Oct 6, 2023

Conversation

CopyDemon
Copy link
Contributor

Based on the new design file, rewrite the UI with React:

Link to design file

  • The new UI should be broken down into components to ensure it's easy to maintain in the future.
  • The new UI should retain the functionalities of the old UI.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@dangunter
Copy link
Member

It now works!
One minor thing: the IDAES logo in the upper-left corner is not found. Maybe the path needs to be relative to the source code not the run directory?

@CopyDemon CopyDemon marked this pull request as ready for review September 21, 2023 18:36
@CopyDemon CopyDemon changed the base branch from move-ui-to-react to main September 28, 2023 18:00
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Sep 28, 2023
Copy link
Member

@dangunter dangunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some places in paper.js where 'var' is used instead of 'let' or 'const'. Could you go through and see if you can replace those? There are very few places var is still needed I think.

@dangunter dangunter self-requested a review October 6, 2023 17:41
Copy link
Member

@dangunter dangunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dangunter dangunter merged commit 372c3ff into IDAES:main Oct 6, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants