Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CI checks for non-editable install #41

Merged
merged 27 commits into from
Dec 6, 2023
Merged

Enable CI checks for non-editable install #41

merged 27 commits into from
Dec 6, 2023

Conversation

lbianchi-lbl
Copy link
Contributor

Resolves #40

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl self-assigned this Nov 28, 2023
@lbianchi-lbl
Bypass local action for installation
e5e2950
@lbianchi-lbl
Disable other jobs while WIP
aa1e0ad
@lbianchi-lbl
Revert "Disable other jobs while WIP"
61651ca 
This reverts commit aa1e0ad.
@lbianchi-lbl
Try reworking install action to abstract installation variants
d9276f9
@lbianchi-lbl
Fix invalid workflow schema
ce666a2
@lbianchi-lbl
Try hardcoding action source since contexts are not available
2ec101c
@lbianchi-lbl
Add missing context
9f5f44b
@lbianchi-lbl
Try using head of PR ref to get current version of action
3a0bd9d
@lbianchi-lbl
Investigate why variant arg is ignored
f59dde5
@lbianchi-lbl
Try making argument required
8533beb
@lbianchi-lbl
Reduce job matrix size while WIP
991b9d5
@lbianchi-lbl
Fix job matrix key
2d74487
@lbianchi-lbl
Revert "Try making argument required"
d6ca581 
This reverts commit 8533beb.
@lbianchi-lbl
Add missing pip install flag
edeb000
@lbianchi-lbl
Add missing quote
33b58e2
@lbianchi-lbl
Fix pip install command
cc98ab4
@lbianchi-lbl
Try making Cypress jobs variant-agnostic
29ace9f
@lbianchi-lbl
Try resolving Cypress action error
fda2e50
@lbianchi-lbl
Add missing Cypress config file to partial checkout
32294c1
@lbianchi-lbl lbianchi-lbl changed the title Enable CI check for non-editable install Enable CI checks for non-editable install Nov 29, 2023
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Nov 30, 2023
@lbianchi-lbl lbianchi-lbl marked this pull request as ready for review December 6, 2023 19:38
@lbianchi-lbl
Copy link
Contributor Author

I'm going to merge this despite the (expected) failures so that the newly added CI checks can be used to verify that #39 works.

@lbianchi-lbl lbianchi-lbl merged commit 66f2e15 into IDAES:main Dec 6, 2023
16 of 33 checks passed
@lbianchi-lbl lbianchi-lbl mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangunter dangunter Awaiting requested review from dangunter

@CopyDemon CopyDemon Awaiting requested review from CopyDemon

Assignees

@lbianchi-lbl lbianchi-lbl

Labels
Priority:High High Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable test suite and CI checks for non-editable installs
3 participants
@lbianchi-lbl @ksbeattie @CopyDemon