Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 45 send back diagram image #51

Open
wants to merge 48 commits into
base: main
Choose a base branch
from
Open

Issue 45 send back diagram image #51

wants to merge 48 commits into from

Conversation

CopyDemon
Copy link
Contributor

Fixes
Related to issue
Project board link

Proposed changes:
User can get and view diagram screenshot in Jupyter notebook

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@CopyDemon CopyDemon mentioned this pull request Aug 7, 2024
Open
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Aug 8, 2024
dangunter
dangunter reviewed Aug 13, 2024
View reviewed changes
idaes_ui/fv/fsvis.py Outdated Show resolved Hide resolved
dangunter
dangunter reviewed Aug 13, 2024
View reviewed changes
idaes_ui/fv/fsvis.py Outdated Show resolved Hide resolved
@CopyDemon CopyDemon marked this pull request as draft August 13, 2024 16:44
@dangunter
Copy link
Member

@lbianchi-lbl suggested a simpler way to approach all this, which I think makes sense. Use standard HTML5 browser APIs to convert the SVG element to a PNG in Javascript. Then the Playwright/Selenium etc. is not required

@CopyDemon
internal function save diagram should return diagram saved path for p…
210a1a0 
…ytest
@CopyDemon
add test diagram save path, work save now test default path
889da65
@CopyDemon
add testing test save path
17f8851
@CopyDemon
add return for test, add if condation to log info to user about path …
16f872f 
…is invalid, add description to function
@CopyDemon
update package list now only use playwright and nest_asyncio these ar…
c04feba 
…e require for test and generate screenshot move to pyproject remove from requirement-dev
@CopyDemon
add Ipython to dependency for only return screenshot to user when use…
940c248 
…r at jupyter env other env will save image not display
@CopyDemon
grammar error fix
18a5a33
@CopyDemon
remove dependency fastapi uvicorn since these are not use
5efba61
@CopyDemon
move playwright to required dependency
f562744
@CopyDemon
add install playwright step for CI
9d803f4
@CopyDemon
testing CI is not install playwright
b5660f1
@CopyDemon
move install playwright to core test why playwright is not installed
aa904a0
@CopyDemon
remove logging capture since not in use, and add log for save path as…
a045dc4 
…sert
@CopyDemon
update CI core add - name: Install playwright
f26e529 
        shell: bash -l {0}
        run
@CopyDemon
update default path defination, it defined within fsvis _validate_and…
eced697 
…_create_save_path()
@CopyDemon
update default path defination, it defined within fsvis _validate_and…
14b0ee5 
…_create_save_path()
@CopyDemon
_validate_and_create_save_path()now return default path for future us…
7b22859 
…e and test use
@CopyDemon
windows show cant move file error and async_save_diagram function ret…
5ccccbc 
…urn none type, try to catch error and also return a file path
@CopyDemon
use shutil replate os.rename in windows the os.rename is not working …
efb183d 
…with move file from one disk to another
@CopyDemon
insted of os.rename or shutil.move now use read and write file to sav…
89ba63e 
…e path to prevent error in change disk in windows, give a try
@CopyDemon
use platfrom and tempfile to create invalid path for windows and linux
d026bf1
@CopyDemon
add function arg description. add if condation default browser downlo…
5550b3b 
…ad path has screenshot file then remove it
@CopyDemon
debug: try remove delete folder code to see if that broken download
89d3ec8
@CopyDemon
increase waiting time for browser to fully load and restore delete do…
4f799c5 
…wnload file in download folder sames like only bug on windows CI
@CopyDemon
continue increase browser waiting time for windows CI
c07a712
@CopyDemon
update browser use no sandbox mode
3be7cb1
@CopyDemon
debug update invalid path on window the CON:\ sames like can cause so…
8403abe 
…me problem
@ksbeattie
Copy link
Member

@CopyDemon what's the news here?

@CopyDemon
Copy link
Contributor Author

@CopyDemon what's the news here?

I'm back working on this issue now. It seems like screenshots are not being saved on Windows. I'm trying to find a Windows computer to test it and determine whether the issue is with pytest or if it's just not saving on Windows.

@CopyDemon CopyDemon marked this pull request as ready for review October 16, 2024 22:45
@ksbeattie ksbeattie linked an issue Oct 24, 2024 that may be closed by this pull request
Add ability to send back diagram image to server #45
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangunter dangunter dangunter left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@CopyDemon CopyDemon

Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to send back diagram image to server
3 participants
@CopyDemon @dangunter @ksbeattie