Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump iviewer 0.14.0 #423

Merged
merged 1 commit into from
Jun 27, 2024
Merged

bump iviewer 0.14.0 #423

merged 1 commit into from
Jun 27, 2024

Conversation

will-moore
Copy link
Member

bump iviewer 0.14.0

cc @jburel

@will-moore
Copy link
Member Author

Build is failing Molecule test:

  File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/urllib3/poolmanager.py", line 326, in connection_from_context
    raise URLSchemeUnknown(scheme)
urllib3.exceptions.URLSchemeUnknown: Not supported URL scheme http+docker

@jburel Any ideas what's going on here?

@sbesson
Copy link
Member

sbesson commented Jun 4, 2024 •
edited
Loading

Pretty sure the build issues are related to the requests 2.32.0 changes discussed in ansible-community/molecule-plugins#257 , docker/docker-py#3256 and psf/requests#6707

As a workaround, @khaledk2 capped the version of requests installed in the workflow - see #424 (comment).

@will-moore
Copy link
Member Author

Rebased and force-pushed. Build now green

@sbesson sbesson requested a review from jburel June 11, 2024 07:54
@sbesson sbesson mentioned this pull request Jun 24, 2024
Merged
will-moore
will-moore commented Jun 26, 2024
View reviewed changes
Copy link
Member Author

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The iviewer upgrade is working as expected on idr-next now.
(I can't approve my own PR but I can give it a 👍 )

jburel
jburel reviewed Jun 27, 2024
View reviewed changes
ansible/group_vars/omero-hosts.yml
@@ -237,7 +237,7 @@ omero_web_config_set:

omero_web_apps_packages:
- omero-mapr==0.5.2
- omero-iviewer==0.13.0
- omero-iviewer==0.14.0
- idr-gallery==3.11.0
- omero-figure==6.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figure is now at 7.0.0 but not really used in IDR

@jburel jburel merged commit a99e654 into IDR:master Jun 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jburel jburel jburel left review comments

@sbesson sbesson sbesson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@will-moore @sbesson @jburel