-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set PS_Mode to 3 #240
set PS_Mode to 3 #240
Conversation
I just pushed updated DISCONs. There were some minor numerical updates to the gains. A major change is that we are now peak shaving at 80% of rated thrust near rated in the monopile model. This will change the thrust-based loads near rated operation. Note that :
This is an old, inherited naming convention that makes sense when you consider that the ROSCO dynamic library only uses the lower pitch limit, which is determined by the ROSCO toolbox tuning. |
@jennirinker - While looking into the pitch scheduling, we noticed a discrepancy in the peak thrust shaving input in WISDEM vs OpenFAST. What do you see in HAWC2? |
Sorry, I need a bit more context to weigh in here. My understanding is that you are proposing two different changes in the same MR:
Is this a correct understanding? Regarding the addition of peak shaving: this is a rather substantial change to the model. Why are we adding it now? It's not in the original docs, so this might confuse people unnecessarily. And if you add peak shaving with ROSCO, I don't know how we can mimic the same behaviour in the HAWC2 model with DTU WEC. So I'm a bit hesitant to greenlight this change without alignment. |
Ah, I think you are correct again, Jenni. I was confusing the details of the 15 and 22 ref turbines. Let's get together to discuss in real-time. |
I think the decision around peak shaving was made because that parameter affects peak blade loading, and it should be shared for both substructures because the rotors are the same. @ptrbortolotti, feel free to weigh in. Peak shaving can be implemented in the DTU WEC through this table: https://github.com/IEAWindTask37/IEA-15-240-RWT/blob/master/HAWC2/IEA-15-240-RWT-Monopile/control/wpdata.101 I reverted ps_percent to 1.0 for now, and am happy to go with the consensus.
^ Technically, this hasn't changed, but the ROSCO DISCONs were due for an update. |
Should PS_Mode 0, 1, 2, or 3? And should it be the same for monopile and platform @dzalkind ? |
|
Merging this in with a comment that we are setting |
Purpose
Allow pitch to vary in reg I1/2, consistently with WISDEM
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.
Checklist
Put an
x
in the boxes that apply.