Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event item refactor & Acceptance Tests #248

Merged
merged 5 commits into from
Mar 14, 2022
Merged

Event item refactor & Acceptance Tests #248

merged 5 commits into from
Mar 14, 2022

Conversation

mumby0168
Copy link
Collaborator

@mumby0168 mumby0168 commented Mar 13, 2022

Introduced some acceptance tests

  1. Tests the persist methods
  2. Tests the read methods
  3. Tests the change feed processing to build projections
  4. Used a single test since the startup time of the library to create containers and DBs etc takes around 20 seconds so running multiple tests just takes longer.

Refactored the DefaultEventStore<T> to use the specific interfaces provided by the repo.

Updated docs to reflect changes to EventItem. This imp of EventItem makes serialization behave better and does not force the consumer to follow any specific ctor implementation.

@mumby0168 mumby0168 marked this pull request as ready for review March 13, 2022 21:15
@mumby0168 mumby0168 requested a review from IEvangelist as a code owner March 13, 2022 21:15
Copy link
Owner

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, :shipit: when you're ready.

@mumby0168 mumby0168 merged commit 3146f5d into main Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants