Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test/cli pivot to osm #44

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Test/cli pivot to osm #44

merged 3 commits into from
Mar 9, 2023

Conversation

jmkerloch
Copy link
Contributor

@jmkerloch jmkerloch commented Mar 9, 2023 •
edited
Loading

  • add end-to-end test for pivot2osm

@github-actions
Copy link

github-actions bot commented Mar 9, 2023 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1016 377 37% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 85974c7 by action🐍

@jmkerloch jmkerloch added the test Related to test label Mar 9, 2023
@jmkerloch jmkerloch self-assigned this Mar 9, 2023
@jmkerloch jmkerloch added this to the sprint3 milestone Mar 9, 2023
@jmkerloch jmkerloch marked this pull request as ready for review March 9, 2023 09:03
@jmkerloch jmkerloch requested a review from a team March 9, 2023 09:03
lgrd
lgrd previously approved these changes Mar 9, 2023
View reviewed changes
@lgrd
Copy link
Collaborator

lgrd commented Mar 9, 2023

Can you add "updated_pivot2osm.json" inside .gitignore ?

@lgrd lgrd dismissed their stale review March 9, 2023 12:48

Can you add "updated_pivot2osm.json" inside .gitignore ? To avoid a PR in one hour ^^

lgrd
lgrd requested changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@lgrd lgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment and it's ok ;)

@jmkerloch jmkerloch requested a review from lgrd March 9, 2023 14:05
@jmkerloch jmkerloch merged commit 268346f into develop Mar 9, 2023
@jmkerloch jmkerloch deleted the test/cli_pivot_to_osm branch March 9, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgrd lgrd lgrd approved these changes

Assignees

@jmkerloch jmkerloch

Labels
test Related to test
Projects
Road2 backlog
Status: ✅ Done
Milestone
sprint3
Development

Successfully merging this pull request may close these issues.
2 participants
@jmkerloch @lgrd