Klayout PyCell integration #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 5, 2024 15:45
-implemented 'conditional compilation' for PyCell code, see documentation in ihp-sg13g2/libs.tech/klayout/python/sg13g2_pycell_lib/__init__.py Signed-off-by: ThomasZecha <zecha@ihp-microelectronics.com>
-fixed issue from IHP open source server regarding remove of tmp-file Signed-off-by: ThomasZecha <zecha@ihp-microelectronics.com>
-eleminate pre-definition of used defines by pre-scanning cell code Signed-off-by: ThomasZecha <zecha@ihp-microelectronics.com>
-added evalution of names used for conditional compilation against process-chain -added catching of PyCell static/dynamic compilation errors for correction of file-path stack-dump -added diagnositc logging of process-chain as well as set defines Signed-off-by: ThomasZecha <zecha@ihp-microelectronics.com>
ThomasZecha
requested review from
KrzysztofHerman and
sergeiandreyev
as code owners
|
On the external machine it does not work properly: |
|
Hi,
did you update the ‘pycell4klayout-api’ submodule?
Regards
Thomas
Von: Krzysztof Herman ***@***.***>
Gesendet: Donnerstag, 22. August 2024 12:06
An: IHP-GmbH/IHP-Open-PDK ***@***.***>
Cc: Thomas Zecha ***@***.***>; Author ***@***.***>
Betreff: Re: [IHP-GmbH/IHP-Open-PDK] Klayout PyCell integration (PR #174)
On the external machine it does not work properly:
ERROR: /$PDK_ROOT/ihp-sg13g2/libs.tech/klayout/python/sg13g2_pycell_lib/__init__.py:183: TypeError: PCellWrapper.__init__() takes 3 positional arguments but 5 were given
/$PDK_ROOT/ihp-sg13g2/libs.tech/klayout/python/sg13g2_pycell_lib/__init__.py:183
/$PDK_ROOT/ihp-sg13g2/libs.tech/klayout/python/sg13g2_pycell_lib/__init__.py:191
/$PDK_ROOT/ihp-sg13g2/libs.tech/klayout/tech/pymacros/autorun.lym:8 (class TypeError)
—
Reply to this email directly, view it on GitHub <#174 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDR7DWHXS2KVNGAOJVIC47LZSWZXJAVCNFSM6AAAAABMALJESWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBUGI3TKNZTGE> .
You are receiving this because you authored the thread. <https://github.com/notifications/beacon/BDR7DWHFMAOTW5DEUUTD37DZSWZXJA5CNFSM6AAAAABMALJESWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUJLB2RG.gif> Message ID: ***@***.*** ***@***.***> >
|
KrzysztofHerman
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-implemented 'conditional compilation' for PyCell code, see
documentation in ihp-sg13g2/libs.tech/klayout/python/sg13g2_pycell_lib/init.py