-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If property can ever have multiple values, require a JSON array #1131
Comments
I am 👍 on the proposal, other than for type which I think we should require be 1:1. Constantly type checking values to see if they're a list or a value is painful and results in hard to find bugs. Note that the current validator even incorrectly errors on the everything_a_list manifest. |
👍 too. Currently
not
|
Agree with @tomcrane on nouns remaining as they are, if only for backwards compatibility. RE:
Here, we're stating that the manifest is a CRM InformationObject, but it's also a (Or are we distinguishing between the manifest JSON file, and the manifest itself?) |
Following this pattern, and #1147 / #1176, we should also define an absolute format for first/last/next/prev references. If we ever allow more than just the URI, then they should always be a JSON object, requiring at least two properties (id and something else). (Reason for 2 properties being that JSON-LD will compact {"id": "foo"} to just "foo") |
My preference would be to explicitly limit them to 1:1 URIs. |
Good proposal. #994. |
I note that the addition of |
👍 agreed at Toronto WG meeting |
Done throughout. Leaving open for the other specs, removing presentation tag. |
Tagging principles so we can document it as a design pattern. |
Removing image, via #1433 |
From this thread:
The proposal is to force all properties that can have multiple values to always be an array, in all APIs.
In the Presentation API, this would be:
label, metadata, description, thumbnail, attribution, rights, logo, type, viewingHint, related, rendering, service, seeAlso, within
This is done in JSON-LD by adding
@container: @set
into the context document for those properties.Note however that JSON-LD 1.0 currently prevents us from doing it for the values of LanguageMaps:
But this is fixed in 1.1 (c.f. #1192)
An example from @workergnome:
The text was updated successfully, but these errors were encountered: