Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preloader animation fixed #25

Closed
wants to merge 0 commits into from

Conversation

shashwatdwi176
Copy link
Contributor

No description provided.

@shashwatdwi176
Copy link
Contributor Author

#18 issue fixed

@k3yss
Copy link
Contributor

k3yss commented May 25, 2023

The implementation works fine but your PR is unreadable because you have wrapped everything inside a new div which messes up the indentation, why not fix the previous implementation...can you try doing that?

@shashwatdwi176
Copy link
Contributor Author

shashwatdwi176 commented May 25, 2023 via email

@k3yss
Copy link
Contributor

k3yss commented May 25, 2023

DW It's fine, for me to review your MR you can follow these steps:

  • Make changes
  • Don't run the npx prettier --write . command
  • run git diff to see the changes you have made. Make sure this time you make the pull request with only the lines changed, the maintainers will indent the code
  • Once you think it can be reviewed make another Pull request or make commits to this one fixing the indentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants