Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firebase Cloud Messaging #52

Merged
merged 14 commits into from
Oct 14, 2020
Merged

Firebase Cloud Messaging #52

merged 14 commits into from
Oct 14, 2020

Conversation

davidgarg20
Copy link
Contributor

No description provided.

@nishantwrp nishantwrp requested a review from krashish8 October 9, 2020 22:37
@krashish8
Copy link
Member

@davidgarg20 Please add fcm-django to pipenv by running pipenv install fcm-django

nishantwrp
nishantwrp previously requested changes Oct 11, 2020
View reviewed changes
Copy link
Collaborator

@nishantwrp nishantwrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is that Pipfile changed but Pipfile.lock didn't.

@davidgarg20
Copy link
Contributor Author

davidgarg20 commented Oct 11, 2020 •
edited
Loading

How is that Pipfile changed but Pipfile.lock didn't.

I didn,t noticed that there was a error while locking. Thats why this happened

@nishantwrp
Copy link
Collaborator

@krashish8 please review.

@krashish8
Copy link
Member

@davidgarg20 The code looks good, however, there are errors with the Lint Checks. Maybe this can fix the raise-missing-from and refer this to fix imported-auth-user.

The imported-auth-user has been recently added in pylint (pylint-dev/pylint-django#244 and pylint-dev/pylint-django#278), that might be the reason those lines didn't produce errors before, right? @nishantwrp

@davidgarg20
Copy link
Contributor Author

@krashish8 Thanks bhaiya for the links to remove error . Errors removed.

krashish8
krashish8 approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@krashish8 krashish8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM!

@krashish8 krashish8 dismissed nishantwrp’s stale review October 14, 2020 02:33

Requested changes were addressed

@krashish8 krashish8 merged commit 4739219 into IIT-BHU-InstiApp:master Oct 14, 2020
@krashish8 krashish8 mentioned this pull request Oct 14, 2020
Merged
@krashish8 krashish8 mentioned this pull request Oct 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krashish8 krashish8 krashish8 approved these changes

@nishantwrp nishantwrp Awaiting requested review from nishantwrp

Assignees

@krashish8 krashish8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidgarg20 @krashish8 @nishantwrp